[dojo-contributors] Allow multiple dojo versions in a page for 1.1?
Jared Jurkiewicz
jared.jurkiewicz at gmail.com
Wed Jan 2 20:01:33 UTC 2008
As long as we have a way to still define globals (yuck), then I think
we're okay. That was my main concern, the whole 'external services
require a global function name' issue. Discussing it at the meeting
would be great, to see if anyone else can think of any gotchas to this
before the change is implemented in trunk.
Sincerely,
-- Jared Jurkiewicz
On Jan 2, 2008 2:29 PM, James Burke <jburke at dojotoolkit.org> wrote:
> On Jan 2, 2008 7:16 AM, Jared Jurkiewicz <jared.jurkiewicz at gmail.com> wrote:
> > This will cause problems with dojo.data, I believe. Specifically,
> > with third-party such as Flickr, which requires a loosely defined
> > function. My area of concern is your statement of
> >
> > > function foo() { /*do something*/ }
> > >
> > > in your module file means that it will not be visible as window.foo.
> > > This limitation is already there for xdomain builds and for IE with
> > > the normal dojo loader, but this change will now make this limitation
> > > uniform. I think this is good, since dojo's behavior will always be
> > > uniform and it encourages proper namespacing of code, but it can cause
> > > issues for people assuming module files work just like normal fil
> > > attached directly via script elements.
> > >
> >
> > Because things like FlickrStore have to set a global function.
> > Otherwise, the Flickr API tiself won't work. What will the solution
> > for that be? Can you test your proposed changes against the
> > dojox.data component? (dojox/data/tests/runTests.html)
> >
> > This sort of major change makes me really nervous. This should be
> > discussed, I think, in the Wednesday weekly meetings before the
> > changes are just committed in.
>
> You can define global functions, you just have to be explicit:
>
> window.myFlickrCallback = function() {}
>
> or perhaps even better:
>
> dojo.global.myFlickrBallback = function() {}
>
> If this change is approved, then I'll be sure to run the unit tests in
> the different browsers. I'm up for discussing the topic at the weekly
> meeting.
>
>
> James
> _______________________________________________
> dojo-contributors mailing list
> dojo-contributors at dojotoolkit.org
> http://dojotoolkit.org/mailman/listinfo/dojo-contributors
>
More information about the dojo-contributors
mailing list